Feat/kubectl rollout history daemonset #1818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
yue9944882
reviewed
Aug 17, 2021
extended/src/main/java/io/kubernetes/client/extended/kubectl/KubectlRolloutHistory.java
Outdated
Show resolved
Hide resolved
extended/src/main/java/io/kubernetes/client/extended/kubectl/KubectlRolloutHistory.java
Outdated
Show resolved
Hide resolved
extended/src/main/java/io/kubernetes/client/extended/kubectl/KubectlRolloutHistory.java
Outdated
Show resolved
Hide resolved
extended/src/main/java/io/kubernetes/client/extended/kubectl/KubectlRolloutHistory.java
Outdated
Show resolved
Hide resolved
| final String directiveMarker = "$patch"; | ||
| Object directive = templateMap.get(directiveMarker); | ||
| if (directive == null) { | ||
| throw new IllegalArgumentException("not a directive patch"); |
There was a problem hiding this comment.
i dont think the SMP directives are mandatory in the patch body, and as SSA(Server) goes GA, we should switch all the usage of SMP to SSA to get rid of these magic markers. can you add a TODO comment over here saying that we prefer to land onto SSA patches in a follow-up?
extended/src/main/java/io/kubernetes/client/extended/kubectl/KubectlRolloutHistory.java
Outdated
Show resolved
Hide resolved
extended/src/main/java/io/kubernetes/client/extended/kubectl/KubectlRolloutHistory.java
Outdated
Show resolved
Hide resolved
extended/src/main/java/io/kubernetes/client/extended/kubectl/KubectlRolloutHistory.java
Outdated
Show resolved
Hide resolved
NeverRaR
force-pushed
the
feat/kubectl-rollout-history-daemonset
branch
8 times, most recently
from
eaf81e6 to
11f1878
Compare
NeverRaR
force-pushed
the
feat/kubectl-rollout-history-daemonset
branch
from
11f1878 to
2957526
Compare
k8s-ci-robot
added
size/XXL
NeverRaR
force-pushed
the
feat/kubectl-rollout-history-daemonset
branch
from
2957526 to
ade222f
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: NeverRaR, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat : support kubectl rollout history for daemonset